-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade etcd-client to 0.12.2 #2781
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
tisonkun
commented
Nov 20, 2023
tisonkun
commented
Nov 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2781 +/- ##
===========================================
- Coverage 84.36% 84.10% -0.26%
===========================================
Files 722 722
Lines 113216 113043 -173
===========================================
- Hits 95513 95076 -437
- Misses 17703 17967 +264 |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Co-authored-by: tison <[email protected]>
MichaelScofield
approved these changes
Nov 21, 2023
cc @fengjiachun |
fengjiachun
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Following I'll create a few follow-ups to improve the code and prepare to add chroot for etcd connection.
Checklist
Refer to a related PR or issue link (optional)